kennknowles commented on PR #26793: URL: https://github.com/apache/beam/pull/26793#issuecomment-1557613350
To clarify one thing: the commit chosen by step 2 has to still be on 2.X.0-SNAPSHOT. I'm not suggesting it can be executed against a commit after step 3 has advanced the version. _But_ it absolutely can be executed independently and afterwards. The commit Z can be the parent of the commit that advances the version. So then you have the equivalent steps: 0. Assuming master is on version 2.X.0-SNAPSHOT 1. Push a commit to move master to 2.(X+1).0-SNAPSHOT 2. Locate the/a last commit with 2.X.0-SNAPSHOT 3. Create the branch release-2.X.0 at said commit I actually like this better. The fact that it breaks people out of thinking of things imperatively and is focused on the goal is a feature IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
