kennknowles commented on PR #26793: URL: https://github.com/apache/beam/pull/26793#issuecomment-1563295909
> > Locate the/a last commit with 2.X.0-SNAPSHOT > > Create the branch release-2.X.0 at said commit > I really don't like this. This logic would be as complex as the entire rest of the script, and it only helps in the failure case (so we're opening ourselves up to just as many failures). Parsing git history for certain contents is not a good pattern for us to follow in our infra scripts unless we 100% need it. Fair enough. I agree that parsing contents is fragile. I don't agree that it focuses on the failure case. Rather, it focuses on idempotent logically necessary facts, and then steps to outcomes. Vs viewing it as primarily an imperative process. You could solve all this with use of tags but I agree it is not worth the complexity. I'm just poking around for ways to re-architect this to be less imperative and fragile in the way that IMO was root cause of the prior issue (trying to revert in order to undo something because steps were coupled) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
