jackdingilian commented on code in PR #28374:
URL: https://github.com/apache/beam/pull/28374#discussion_r1327496574
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableConfig.java:
##########
@@ -156,6 +162,12 @@ public BigtableConfig withEmulator(String emulatorHost) {
return toBuilder().setEmulatorHost(emulatorHost).build();
}
+ @VisibleForTesting
+ BigtableConfig withBigtableClientOverride(BigtableClientOverride
clientOverride) {
+ checkArgument(clientOverride != null, "clientOverride can not be null");
Review Comment:
good point, I guess this check isn't really necessary. I'll remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
