kennknowles commented on code in PR #28374:
URL: https://github.com/apache/beam/pull/28374#discussion_r1327629142
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableConfig.java:
##########
@@ -156,6 +162,12 @@ public BigtableConfig withEmulator(String emulatorHost) {
return toBuilder().setEmulatorHost(emulatorHost).build();
}
+ @VisibleForTesting
+ BigtableConfig withBigtableClientOverride(BigtableClientOverride
clientOverride) {
+ checkArgument(clientOverride != null, "clientOverride can not be null");
Review Comment:
OK that seems fine. It is backwards-compatible to start to allow nulls as a
way to re-clear it. One reason to allow nulls is to allow someone to make a
copy without forcing them to `if (!= null) { set it }` but just be able to do
straight-line `set to same value, whether or not it is null`
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -1988,6 +1989,24 @@ public ReadChangeStream
withMetadataTableAppProfileId(String appProfileId) {
.build();
}
+ /**
+ * Returns a new {@link BigtableIO.ReadChangeStream} that overrides the
config of data and/or
+ * admin client for streaming changes and for managing the metadata. For
testing purposes only.
+ * Not intended for use.
+ *
+ * <p>Does not modify this object.
+ */
+ @VisibleForTesting
Review Comment:
Oh I misread the whole change and thought there were already options for
this (those do tend to be useful for redirecting a whole test at a different
bigtable env or local endpoint). Nevermind for now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
