jackdingilian commented on code in PR #28374:
URL: https://github.com/apache/beam/pull/28374#discussion_r1327512731
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableConfig.java:
##########
@@ -156,6 +162,12 @@ public BigtableConfig withEmulator(String emulatorHost) {
return toBuilder().setEmulatorHost(emulatorHost).build();
}
+ @VisibleForTesting
+ BigtableConfig withBigtableClientOverride(BigtableClientOverride
clientOverride) {
+ checkArgument(clientOverride != null, "clientOverride can not be null");
Review Comment:
on second thought, all of the other withParameter functions here have
similar null checks that wouldn't allow overrides.
I'm leaning towards keeping this to be consistent. I don't think there's a
good reason to ever set this and then clear it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
