jackdingilian commented on code in PR #28374:
URL: https://github.com/apache/beam/pull/28374#discussion_r1327498919


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -1988,6 +1989,24 @@ public ReadChangeStream 
withMetadataTableAppProfileId(String appProfileId) {
           .build();
     }
 
+    /**
+     * Returns a new {@link BigtableIO.ReadChangeStream} that overrides the 
config of data and/or
+     * admin client for streaming changes and for managing the metadata. For 
testing purposes only.
+     * Not intended for use.
+     *
+     * <p>Does not modify this object.
+     */
+    @VisibleForTesting

Review Comment:
   IIUC this would require exposing all of the override parameters as 
PipelineOptions to users? We use this to connect to our internal testing 
environment. It requires fairly complicated client settings overrides that I 
don't think would ever be useful to expose to users



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to