Abacn commented on code in PR #28477:
URL: https://github.com/apache/beam/pull/28477#discussion_r1327785313
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamJoinTransforms.java:
##########
@@ -116,6 +116,7 @@ public JoinAsLookup(
this.outputSchema = outputSchema;
this.factColOffset = factColOffset;
joinFieldsMapping(joinCondition, factColOffset, lkpColOffset);
+ this.seekableTable.setJoinSubsetType(joinSubsetType);
Review Comment:
Will this work? at this point `JoinAsLookup.joinSubsetType` is used before
assigned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
