Abacn commented on code in PR #28477:
URL: https://github.com/apache/beam/pull/28477#discussion_r1330291438
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java:
##########
@@ -28,8 +29,12 @@
* FROM FACT_TABLE JOIN LOOKUP_TABLE ON ...}.
*/
public interface BeamSqlSeekableTable extends Serializable {
- /** prepare the instance. */
- default void setUp() {}
+ /**
+ * prepare the instance
+ *
+ * @param joinSubsetType joining subset schema
+ */
+ default void setUp(Schema joinSubsetType) {}
Review Comment:
this could be a breaking change if other developer has implemented setUp()
in their BeamSqlSeekableTable. Let's add this change to CHANGES.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
