Abacn commented on code in PR #28477:
URL: https://github.com/apache/beam/pull/28477#discussion_r1328030621
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java:
##########
@@ -28,6 +29,7 @@
* FROM FACT_TABLE JOIN LOOKUP_TABLE ON ...}.
*/
public interface BeamSqlSeekableTable extends Serializable {
+ default void setJoinSubsetType(Schema joinSubsetType) {}
Review Comment:
my concern is that having a `setJoinSubsetType` method then
`BeamSqlSeekableTable` should really be an abstract class instead of a
Interface. Implying a state in interface method is antipattern (and actually
Java forbids to have interface member for this reason).
pass in setUp() indeed sounds more reasonable -- in this way it will need an
overwrite method for BeamSqlSeekableTable.setUp()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
