Abacn commented on code in PR #28477:
URL: https://github.com/apache/beam/pull/28477#discussion_r1327793796
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java:
##########
@@ -28,6 +29,7 @@
* FROM FACT_TABLE JOIN LOOKUP_TABLE ON ...}.
*/
public interface BeamSqlSeekableTable extends Serializable {
+ default void setJoinSubsetType(Schema joinSubsetType) {}
Review Comment:
This is error prone - while it suggests calling this method will "set
JoinSubsetType", the default implementation does not do anything
I understand we cannot add "throw NotImplementedException" here either for
compatibility reason.
BeamSqlSeekableTable is an interface so it does not hold members. Is there
an elegant way to make joinSubsetType available in
BeamSqlSeekableTable.processElement run time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
