Abacn commented on code in PR #29127:
URL: https://github.com/apache/beam/pull/29127#discussion_r1370876890
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/common/GcpIoPipelineOptionsRegistrar.java:
##########
@@ -38,6 +39,7 @@ public Iterable<Class<? extends PipelineOptions>>
getPipelineOptions() {
.add(PubsubOptions.class)
.add(FirestoreOptions.class)
.add(TestBigQueryOptions.class)
+ .add(BigtableTestOptions.class)
Review Comment:
If this is the only place that refers to BigtableTestOption class, it's not
necessary to move the Option class. We can register the option in the test
class.
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableTestOptions.java:
##########
@@ -28,10 +28,4 @@ public interface BigtableTestOptions extends
TestPipelineOptions {
String getInstanceId();
void setInstanceId(String value);
-
- @Description("Project for Bigtable")
Review Comment:
Interesting that this file has been moved back and forth:
https://github.com/apache/beam/commit/4833b3ff4db57a2f21e5fa1f0200ee4d838ef686
what is the consideration that moving this back to main?
Also, what is the context that removing "setBigtableProject" option? In
theory the project that Bigtable instance locates can be different from the
project used to run Dataflow.
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableTestUtils.java:
##########
@@ -144,4 +146,24 @@ private static Cell createCell(ByteString value, long
timestamp, String... label
}
return builder.build();
}
+
+ public static BigtableIO.ReadChangeStream buildTestPipelineInput(
Review Comment:
if this is the only method that
org.apache.beam.sdk.io.gcp.bigtable.changestreams.it refers to, it is not
necessary to change the Util to public class. Just spin up the pipeline in
place or Create BigtableChangeStreamTestUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
