tonytanger commented on code in PR #29127:
URL: https://github.com/apache/beam/pull/29127#discussion_r1371878782
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableTestOptions.java:
##########
@@ -28,10 +28,4 @@ public interface BigtableTestOptions extends
TestPipelineOptions {
String getInstanceId();
void setInstanceId(String value);
-
- @Description("Project for Bigtable")
Review Comment:
A few reasons.
1. I'm moving it so I can register it in
`GcpIoPipelineOptionsRegistrar.java` for reasons explained in the comment below.
2. I'm removing `setBigtableProject` because of the reason below, we can't
actually set `bigtableProject` to pass to the tests anyways. So I don't think
anything is depending on this so it should be safely removable.
3. By registering `bigtableProject`, it conflicts with some of the tests we
have because they also try to register `bigtableProject`. So it was either
remove here or change it in the tests.
4. I took a brief look at firestore and spanner, neither has an option to
set a different project. So it doesn't seem like it's a common use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
