tonytanger commented on code in PR #29127:
URL: https://github.com/apache/beam/pull/29127#discussion_r1371868811
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableTestUtils.java:
##########
@@ -144,4 +146,24 @@ private static Cell createCell(ByteString value, long
timestamp, String... label
}
return builder.build();
}
+
+ public static BigtableIO.ReadChangeStream buildTestPipelineInput(
Review Comment:
The problem, which we (bigtable team) dug ourselves into, is that `endTime`
is a package private field. We don't want to expose `endTime` as an option
because it's generally not well supported. But `endTime` is useful to terminate
tests.
So we have to create the pipeline in the same package as `BigtableIO` so we
actually can't create the pipeline with `endTime` in the `changestreams`
package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
