tonytanger commented on code in PR #29127:
URL: https://github.com/apache/beam/pull/29127#discussion_r1371865380
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/common/GcpIoPipelineOptionsRegistrar.java:
##########
@@ -38,6 +39,7 @@ public Iterable<Class<? extends PipelineOptions>>
getPipelineOptions() {
.add(PubsubOptions.class)
.add(FirestoreOptions.class)
.add(TestBigQueryOptions.class)
+ .add(BigtableTestOptions.class)
Review Comment:
Maybe there's an alternate solution. I want to be able to pass in
"instanceId" as a parameter to the IT. But gcp project defines
`integrationTest` to explicitly take a few parameters and pass them to beam
`beamTestPipelineOptions`. So I added `instanceId`. But, unless `instanceId` is
always defined (by registering it for all ITs), other tests fail because they
don't have `instanceId` defined but we're passing `instanceId`.
So this ended up being the solution. Happy to try something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
