Abacn commented on code in PR #29127:
URL: https://github.com/apache/beam/pull/29127#discussion_r1376780302
##########
sdks/java/io/google-cloud-platform/build.gradle:
##########
@@ -187,12 +187,14 @@ task integrationTest(type: Test, dependsOn:
processTestResources) {
def gcpTempRoot = project.findProperty('gcpTempRoot') ?:
'gs://temp-storage-for-end-to-end-tests'
def firestoreDb = project.findProperty('firestoreDb') ?: 'firestoredb'
def host = project.findProperty('host') ?:
'batch-firestore.googleapis.com:443'
+ def instanceId = project.findProperty('instanceId') ?: 'beam-test'
systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
"--runner=DirectRunner",
"--project=${gcpProject}",
"--tempRoot=${gcpTempRoot}",
"--firestoreDb=${firestoreDb}",
"--host=${host}",
+ "--instanceId=${instanceId}",
Review Comment:
> This works fine for ChangeStreamIT because it registers
BigtableTestOptions which defines instanceId, so we can pass --instanceId to
beamTestPipelineOptions. However, all other integration tests that do not
register BigtableTestOptions will fail because we are passing --instanceId to
beamTestPipelineOptions but they don't have an option that reigsters instanceId.
Thanks, understand. For irrelevant test this was due to `--instanceId`
pipeline option not recognized, as you stated. This happens because currently
all gcp integration tests are triggered by a single gradle command. Restructure
test is a more substantial change. For now, we can keep it in main if this is
the only approach to make it work, but consider to make the option specialized,
like
- use "--bigtableInstanceId" instanceId is too generic. The options in main
scope will affect all users including customers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
