Abacn commented on code in PR #29127:
URL: https://github.com/apache/beam/pull/29127#discussion_r1376606582
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/common/GcpIoPipelineOptionsRegistrar.java:
##########
@@ -38,6 +39,7 @@ public Iterable<Class<? extends PipelineOptions>>
getPipelineOptions() {
.add(PubsubOptions.class)
.add(FirestoreOptions.class)
.add(TestBigQueryOptions.class)
+ .add(BigtableTestOptions.class)
Review Comment:
In each IT class, one can get a TestPipelineOptions instance like this
https://github.com/apache/beam/blob/8a28100c47b15cf04ec76aba2e1d00fd760aeebd/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOJsonIT.java#L69
and then one can use testOptions.as(BigtableTestOptions.class) to get
BigtableTestOptions, e.g.
https://github.com/apache/beam/blob/8a28100c47b15cf04ec76aba2e1d00fd760aeebd/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOJsonIT.java#L372
No Registrar involved. Current Bigtable ITs is doing similar things and it
should suffice.
https://github.com/apache/beam/blob/ba0259de7f9f2d9e06108de20ef57b16ef8e3cc4/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/changestreams/it/BigtableChangeStreamIT.java#L80C5-L80C12
> unless instanceId is always defined (by registering it for all ITs), other
tests fail because they don't have instanceId defined but we're passing
instanceId.
That is because "registering it for all ITs". If we do not register it for
all ITs then irrelevant tests won't fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
