Abacn commented on code in PR #29928:
URL: https://github.com/apache/beam/pull/29928#discussion_r1446346349
##########
sdks/python/apache_beam/runners/portability/local_job_service_main.py:
##########
@@ -155,7 +155,7 @@ def run(argv):
os.unlink(options.port_file)
-def serve(msg, job_servicer):
Review Comment:
if i understood correctly "job_servicer" is unused for now, not sure it
indicates this paremeter is redundant.
##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -731,7 +731,7 @@ def state(self):
A PipelineState object.
"""
if not self.has_job:
- return PipelineState.UNKNOWN
Review Comment:
I don't think this is correct. self.has_job being false is a symptom
suggesting support in fetching job info is incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
