dermasmid commented on code in PR #29928:
URL: https://github.com/apache/beam/pull/29928#discussion_r1446996990
##########
sdks/python/apache_beam/runners/portability/local_job_service_main.py:
##########
@@ -155,7 +155,7 @@ def run(argv):
os.unlink(options.port_file)
-def serve(msg, job_servicer):
Review Comment:
i did it because `serve` sounds like its starting the server while its only
logging in a loop, it was confusing, so i removed `job_servicer` to make it a
bit clearer that its not starting the server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
