dermasmid commented on code in PR #29928:
URL: https://github.com/apache/beam/pull/29928#discussion_r1447002192
##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -731,7 +731,7 @@ def state(self):
A PipelineState object.
"""
if not self.has_job:
- return PipelineState.UNKNOWN
Review Comment:
im targeting for this case:
https://github.com/Triple-Whale/beam/blob/094eb7dc5d7bc9f3de9ef57e8d764f0d8defe037/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L480
since this is in the DataflowPipelineResult i think its safe to assume this
is only used on completion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
