robertwb commented on code in PR #29928:
URL: https://github.com/apache/beam/pull/29928#discussion_r1451047943
##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -731,7 +731,7 @@ def state(self):
A PipelineState object.
"""
if not self.has_job:
- return PipelineState.UNKNOWN
Review Comment:
Is the issue here that we need a terminal (presumably non-failure) state?
I think this is OK--we are done uploading the template, but have no idea
what the state of the job(s) is/are. It's worth a comment at least (both here
and where we set it indicating that a None job is interpreted as success).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
