lostluck commented on code in PR #29900:
URL: https://github.com/apache/beam/pull/29900#discussion_r1446705476
##########
sdks/go/pkg/beam/core/timers/timers.go:
##########
@@ -53,6 +53,7 @@ type TimerMap struct {
type timerConfig struct {
Tag string
+ HoldSet bool
Review Comment:
In this case, it's relating to whether the "Hold Timestamp was Set By the
User", so the Set is more about "Get+Set" rather than the mathematical or
computer science notion of Set. I can add a comment (will resolve when changed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
