lostluck commented on code in PR #29900:
URL: https://github.com/apache/beam/pull/29900#discussion_r1446708868
##########
sdks/go/pkg/beam/runners/prism/internal/engine/data.go:
##########
@@ -39,6 +39,8 @@ type TentativeData struct {
// state is a map from transformID + UserStateID, to window, to
userKey, to datavalues.
state map[LinkID]map[typex.Window]map[string]StateData
+ // timers is a map from transformID + UserStateID, to window, to
userKey, to datavalues.
Review Comment:
Yes. It's a slice of serialized timers data. The field represents *all*
timers involved in the bundle, so plural is correct. I should correct that
copy-pasta "datavalues" in the comment.
I was mostly lazy about defining a new externalized key type, so I re-used
the LinkID type while getting this working, which is the same kind of tuple.
I'm more than happy to add a specific "TimerKey" type that can be used instead.
LinkID is basically a generic ID for indicating a tuple of
Transform+LocalRef+GlobalRef strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
