damondouglas commented on code in PR #30847: URL: https://github.com/apache/beam/pull/30847#discussion_r1566440957
########## .test-infra/terraform/google-cloud-platform/utility-cluster/strimzi-contoller.tf: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +resource "helm_release" "strimzi-helm-release" { + name = "strimzi" + namespace = "strimzi" + create_namespace = true + repository = "https://strimzi.io/charts/"; + chart = "strimzi-kafka-operator" + version = "0.40.0" + + atomic = "true" + timeout = 500 + + set { + name = "watchAnyNamespace" + value = "true" + } + depends_on = [ module.gke.google_container_cluster ] +} + Review Comment: In my experience, I find co-mingling GKE provisioning with Kubernetes workload provisioning in the same terraform module to lead to problems in the future. I personally would like to see it in a separate module. I'm more than willing to defer to another Apache Beam committer's opinion, if they think the co-mingling design is ok and have a logical well articulated reason. Otherwise, I'm not comfortable approving this PR with the current design. In summary, my design preference is: 1) separate GKE provisioning module - a version controlled tfvars file in the existing `.test-infra/terraform/google-cloud-platform/google-kubernetes-engine` folder could work 2) separate folder responsible for provisioning the strimzi cluster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
