damondouglas commented on code in PR #30847:
URL: https://github.com/apache/beam/pull/30847#discussion_r1554017589


##########
.test-infra/terraform/google-cloud-platform/google-kubernetes-engine/cluster.tf:
##########
@@ -34,7 +34,9 @@ resource "google_container_cluster" "default" {
     enable_private_nodes    = true
     enable_private_endpoint = false
   }
-  node_config {
-    service_account = data.google_service_account.default.email
+  cluster_autoscaling {

Review Comment:
   What happened when you tested this terraform module then? Were you able to 
successfully deploy the kafka cluster? The autopilot terraform specification 
changes rapidly but I had some success recently with:
   ```
   resource "google_container_cluster" "default" {
     name                = var.resource_name
     deletion_protection = false
     location            = var.region
     enable_autopilot    = true
     network             = google_compute_network.default.id
     subnetwork          = google_compute_subnetwork.default.id
     private_cluster_config {
       enable_private_nodes    = true
       enable_private_endpoint = false
     }
     cluster_autoscaling {
       auto_provisioning_defaults {
         service_account = google_service_account.default.email
         oauth_scopes    = [
           "https://www.googleapis.com/auth/cloud-platform";
         ]
       }
     }
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to