volatilemolotov commented on code in PR #30847:
URL: https://github.com/apache/beam/pull/30847#discussion_r1553535538
##########
.test-infra/terraform/google-cloud-platform/google-kubernetes-engine/cluster.tf:
##########
@@ -34,7 +34,9 @@ resource "google_container_cluster" "default" {
enable_private_nodes = true
enable_private_endpoint = false
}
- node_config {
- service_account = data.google_service_account.default.email
+ cluster_autoscaling {
Review Comment:
Yes but keep in mind that changing `node_config` on autopilot clusters needs
additional defaults added because it will try to overwrite the config if i just
put the scope mentioned
second apply without changes:
```
oauth_scopes = [ # forces replacement
- "https://www.googleapis.com/auth/userinfo.email";,
# (1 unchanged element hidden)
]
reservation_affinity { # forces replacement
- consume_reservation_type = "NO_RESERVATION" -> null # forces
replacement
- values = [] -> null
}
```
It will work when I add `userinfo.email` scope
```
node_config {
oauth_scopes = [
"https://www.googleapis.com/auth/cloud-platform";,
"https://www.googleapis.com/auth/userinfo.email";
]
reservation_affinity {
consume_reservation_type = "NO_RESERVATION"
}
}
```
Reservation affinity also must be specified as it also tries to overwrite
that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
