damondouglas commented on code in PR #30847:
URL: https://github.com/apache/beam/pull/30847#discussion_r1551939749
##########
.test-infra/terraform/google-cloud-platform/google-kubernetes-engine/cluster.tf:
##########
@@ -34,7 +34,9 @@ resource "google_container_cluster" "default" {
enable_private_nodes = true
enable_private_endpoint = false
}
- node_config {
- service_account = data.google_service_account.default.email
+ cluster_autoscaling {
Review Comment:
Thank you for changing this! Could we also add the oauth scope for Google
cloud platform? https://www.googleapis.com/auth/cloud-platform
##########
.test-infra/terraform/google-cloud-platform/google-kubernetes-engine/outputs.tf:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+output kubernetes_api_endpoint {
+ value = google_container_cluster.default.endpoint
+}
+
+output cluster_ca_certificate {
Review Comment:
Thank you for adding outputs :-). Could you tell me what this output is
needed for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
