m-trieu commented on code in PR #31504:
URL: https://github.com/apache/beam/pull/31504#discussion_r1634257164
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/AbstractWindmillStream.java:
##########
@@ -238,7 +239,7 @@ public final void appendSummaryHtml(PrintWriter writer) {
protected abstract void appendSpecificHtml(PrintWriter writer);
@Override
- public final synchronized void close() {
+ public synchronized void close() {
Review Comment:
override is in GetDataStream since we want to clear all of the batches to
prevent dangling calls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
