m-trieu commented on code in PR #31504:
URL: https://github.com/apache/beam/pull/31504#discussion_r1634270512
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/Work.java:
##########
@@ -171,6 +181,10 @@ public State getState() {
return currentState.state();
}
+ public @Nullable GetDataStream getDataStream() {
Review Comment:
done
moved all functionality of heartbeats to the new HeartbeatSender interface
we can group by HeartbeatSender
dispatched SE and SA will have only 1 HeartbeatSender so these requests will
all go to the same endpoint/receiver
direct path will fan out since there will be multiple HeartbeatSenders in
the heartbeat request
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillStreamFactory.java:
##########
@@ -209,11 +261,29 @@ public GetWorkerMetadataStream
createGetWorkerMetadataStream(
onNewWindmillEndpoints);
}
- private StreamObserverFactory newStreamObserverFactory() {
+ private StreamObserverFactory newBufferringStreamObserverFactory() {
Review Comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
