m-trieu commented on code in PR #31504:
URL: https://github.com/apache/beam/pull/31504#discussion_r1643812279
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/MetricTrackingWindmillServerStub.java:
##########
@@ -278,47 +278,82 @@ public Windmill.GlobalData
getSideInputData(Windmill.GlobalDataRequest request)
}
}
- /** Tells windmill processing is ongoing for the given keys. */
- public void refreshActiveWork(Map<String, List<HeartbeatRequest>>
heartbeats) {
+ public Windmill.GlobalData getSideInputData(
+ GetDataStream getDataStream, Windmill.GlobalDataRequest request) {
+ gcThrashingMonitor.waitForResources("GetSideInputData");
+ activeSideInputs.getAndIncrement();
+ try {
+ return getDataStream.requestGlobalData(request);
+ } catch (Exception e) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
