m-trieu commented on code in PR #31504:
URL: https://github.com/apache/beam/pull/31504#discussion_r1634271808
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillStreamFactory.java:
##########
@@ -209,11 +261,29 @@ public GetWorkerMetadataStream
createGetWorkerMetadataStream(
onNewWindmillEndpoints);
}
- private StreamObserverFactory newStreamObserverFactory() {
+ private StreamObserverFactory newBufferringStreamObserverFactory() {
return StreamObserverFactory.direct(
DEFAULT_STREAM_RPC_DEADLINE_SECONDS * 2,
windmillMessagesBetweenIsReadyChecks);
}
+ /**
+ * Simple {@link StreamObserverFactory} that does not buffer or provide
extra functionality for
+ * request observers.
+ *
+ * @implNote Used to create stream observers for direct path streams that do
not share any
+ * underlying resources between threads.
+ */
+ private StreamObserverFactory newSimpleStreamObserverFactory() {
Review Comment:
gotcha we may want to bump the deadline then
```
"Exceeded timeout waiting for the outboundObserver to become ready meaning "
+ "that the stream deadline was not respected."
```
was getting a lot of these errors in testing.
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
