m-trieu commented on code in PR #31784:
URL: https://github.com/apache/beam/pull/31784#discussion_r1696150162
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/commits/StreamingEngineWorkCommitter.java:
##########
@@ -69,40 +71,44 @@ private StreamingEngineWorkCommitter(
new ThreadFactoryBuilder()
.setDaemon(true)
.setPriority(Thread.MAX_PRIORITY)
- .setNameFormat("CommitThread-%d")
+ .setNameFormat(
+ backendWorkerToken.isEmpty()
+ ? "CommitThread-%d"
+ : "CommitThread-" + backendWorkerToken + "-%d")
.build());
this.activeCommitBytes = new AtomicLong();
this.onCommitComplete = onCommitComplete;
this.numCommitSenders = numCommitSenders;
this.isRunning = new AtomicBoolean(false);
}
- public static StreamingEngineWorkCommitter create(
- Supplier<CloseableStream<CommitWorkStream>> commitWorkStreamFactory,
- int numCommitSenders,
- Consumer<CompleteCommit> onCommitComplete) {
- return new StreamingEngineWorkCommitter(
- commitWorkStreamFactory, numCommitSenders, onCommitComplete);
+ public static Builder builder() {
+ return new AutoBuilder_StreamingEngineWorkCommitter_Builder()
+ .setBackendWorkerToken("")
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
