m-trieu commented on code in PR #31784:
URL: https://github.com/apache/beam/pull/31784#discussion_r1696153550
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/getdata/StreamPoolGetDataClient.java:
##########
@@ -18,33 +18,29 @@
package org.apache.beam.runners.dataflow.worker.windmill.client.getdata;
import java.io.PrintWriter;
-import java.util.Map;
import javax.annotation.concurrent.ThreadSafe;
import org.apache.beam.runners.dataflow.worker.windmill.Windmill;
import
org.apache.beam.runners.dataflow.worker.windmill.Windmill.GlobalDataRequest;
import
org.apache.beam.runners.dataflow.worker.windmill.Windmill.KeyedGetDataRequest;
import org.apache.beam.runners.dataflow.worker.windmill.client.CloseableStream;
import
org.apache.beam.runners.dataflow.worker.windmill.client.WindmillStream.GetDataStream;
import
org.apache.beam.runners.dataflow.worker.windmill.client.WindmillStreamPool;
-import
org.apache.beam.runners.dataflow.worker.windmill.work.refresh.HeartbeatSender;
-import
org.apache.beam.runners.dataflow.worker.windmill.work.refresh.Heartbeats;
import org.apache.beam.sdk.annotations.Internal;
-import
org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Iterables;
/**
* StreamingEngine implementation of {@link GetDataClient}.
*
- * @implNote Uses {@link WindmillStreamPool} to send/receive requests.
Depending on options, may use
- * a dedicated stream pool for heartbeats.
+ * @implNote Uses {@link WindmillStreamPool} to send requests. Depending on
options, may use a
+ * dedicated stream pool for heartbeats.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
