m-trieu commented on code in PR #31784:
URL: https://github.com/apache/beam/pull/31784#discussion_r1696342614
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/refresh/Heartbeats.java:
##########
@@ -45,21 +46,32 @@ public abstract static class Builder {
abstract ImmutableList.Builder<RefreshableWork> workBuilder();
- public final Builder addWork(RefreshableWork work) {
+ public final Builder add(
+ String computationId, RefreshableWork work,
DataflowExecutionStateSampler sampler) {
workBuilder().add(work);
+ addHeartbeatRequest(computationId, createHeartbeatRequest(work,
sampler));
return this;
}
+ private Windmill.HeartbeatRequest createHeartbeatRequest(
+ RefreshableWork work, DataflowExecutionStateSampler sampler) {
+ return Windmill.HeartbeatRequest.newBuilder()
+ .setShardingKey(work.getShardedKey().shardingKey())
+ .setWorkToken(work.id().workToken())
+ .setCacheToken(work.id().cacheToken())
+
.addAllLatencyAttribution(work.getHeartbeatLatencyAttributions(sampler))
+ .build();
+ }
+
abstract Builder setHeartbeatRequests(
ImmutableListMultimap<String, Windmill.HeartbeatRequest> value);
abstract ImmutableListMultimap.Builder<String, Windmill.HeartbeatRequest>
heartbeatRequestsBuilder();
- public final Builder addHeartbeatRequest(
+ private void addHeartbeatRequest(
Review Comment:
done
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/refresh/Heartbeats.java:
##########
@@ -45,21 +46,32 @@ public abstract static class Builder {
abstract ImmutableList.Builder<RefreshableWork> workBuilder();
- public final Builder addWork(RefreshableWork work) {
+ public final Builder add(
+ String computationId, RefreshableWork work,
DataflowExecutionStateSampler sampler) {
workBuilder().add(work);
+ addHeartbeatRequest(computationId, createHeartbeatRequest(work,
sampler));
return this;
}
+ private Windmill.HeartbeatRequest createHeartbeatRequest(
+ RefreshableWork work, DataflowExecutionStateSampler sampler) {
+ return Windmill.HeartbeatRequest.newBuilder()
+ .setShardingKey(work.getShardedKey().shardingKey())
+ .setWorkToken(work.id().workToken())
+ .setCacheToken(work.id().cacheToken())
+
.addAllLatencyAttribution(work.getHeartbeatLatencyAttributions(sampler))
+ .build();
+ }
+
abstract Builder setHeartbeatRequests(
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
