m-trieu commented on code in PR #31784:
URL: https://github.com/apache/beam/pull/31784#discussion_r1696153305
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/commits/StreamingEngineWorkCommitter.java:
##########
@@ -214,11 +216,13 @@ private boolean tryAddToCommitBatch(Commit commit,
CommitWorkStream.RequestBatch
return isCommitAccepted;
}
- // Helper to batch additional commits into the commit batch as long as they
fit.
- // Returns a commit that was removed from the queue but not consumed or null.
- private Commit expandBatch(CommitWorkStream.RequestBatcher batcher) {
+ /**
+ * Helper to batch additional commits into the commit batch as long as they
fit. Returns a commit
+ * that was removed from the queue but not consumed or null.
+ */
+ private @Nullable Commit expandBatch(CommitWorkStream.RequestBatcher
batcher) {
int commits = 1;
- while (true) {
+ while (isRunning.get()) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
