m-trieu commented on code in PR #31902:
URL: https://github.com/apache/beam/pull/31902#discussion_r1792474537
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillStreamFactory.java:
##########
@@ -240,7 +276,22 @@ public CommitWorkStream createCommitWorkStream(
NO_BACKEND_WORKER_TOKEN,
responseObserver ->
withDefaultDeadline(stub).commitWorkStream(responseObserver),
grpcBackOff.get(),
- newStreamObserverFactory(),
+ newStreamObserverFactory(DEFAULT_DEADLINE_SECONDS),
+ streamRegistry,
+ logEveryNStreamFailures,
+ commitWorkThrottleTimer,
+ jobHeader,
+ streamIdGenerator,
+ streamingRpcBatchLimit);
+ }
+
+ public CommitWorkStream createDirectCommitWorkStream(
+ WindmillConnection connection, ThrottleTimer commitWorkThrottleTimer) {
+ return GrpcCommitWorkStream.create(
+ connection.backendWorkerToken(),
+ responseObserver ->
connection.stub().commitWorkStream(responseObserver),
+ grpcBackOff.get(),
+ newStreamObserverFactory(NO_DEADLINE),
Review Comment:
maybe we can just have a DEFAULT DEADLINE of 300 seconds and then a
DIRECT_DEADLINE of 10 minutes?
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcGetWorkerMetadataStream.java:
##########
@@ -99,11 +94,10 @@ public static GrpcGetWorkerMetadataStream create(
streamRegistry,
logEveryNStreamFailures,
jobHeader,
- metadataVersion,
getWorkerMetadataThrottleTimer,
serverMappingUpdater);
- LOG.info("Started GetWorkerMetadataStream. {}", getWorkerMetadataStream);
getWorkerMetadataStream.startStream();
+ LOG.info("Started GetWorkerMetadataStream. {}", getWorkerMetadataStream);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
