m-trieu commented on code in PR #31902:
URL: https://github.com/apache/beam/pull/31902#discussion_r1792483800
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/budget/EvenGetWorkBudgetDistributor.java:
##########
@@ -37,9 +35,12 @@
final class EvenGetWorkBudgetDistributor implements GetWorkBudgetDistributor {
private static final Logger LOG =
LoggerFactory.getLogger(EvenGetWorkBudgetDistributor.class);
private final Supplier<GetWorkBudget> activeWorkBudgetSupplier;
+ private final boolean shouldConsiderRemainingBudget;
- EvenGetWorkBudgetDistributor(Supplier<GetWorkBudget>
activeWorkBudgetSupplier) {
+ EvenGetWorkBudgetDistributor(
+ Supplier<GetWorkBudget> activeWorkBudgetSupplier, boolean
shouldConsiderRemainingBudget) {
this.activeWorkBudgetSupplier = activeWorkBudgetSupplier;
Review Comment:
eventually the budgeting logic will take into account how much active budget
there is currently on the user worker will send links on chat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
