m-trieu commented on code in PR #31902:
URL: https://github.com/apache/beam/pull/31902#discussion_r1792479646
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/observers/DirectStreamObserver.java:
##########
@@ -39,7 +39,9 @@
@ThreadSafe
public final class DirectStreamObserver<T> implements StreamObserver<T> {
Review Comment:
we need to remove the blocking outside of the lock or else terminating the
stream will be held up by the deadline waiting for a response
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
