m-trieu commented on code in PR #31902:
URL: https://github.com/apache/beam/pull/31902#discussion_r1794449496
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillStreamFactory.java:
##########
@@ -240,7 +276,22 @@ public CommitWorkStream createCommitWorkStream(
NO_BACKEND_WORKER_TOKEN,
responseObserver ->
withDefaultDeadline(stub).commitWorkStream(responseObserver),
grpcBackOff.get(),
- newStreamObserverFactory(),
+ newStreamObserverFactory(DEFAULT_DEADLINE_SECONDS),
+ streamRegistry,
+ logEveryNStreamFailures,
+ commitWorkThrottleTimer,
+ jobHeader,
+ streamIdGenerator,
+ streamingRpcBatchLimit);
+ }
+
+ public CommitWorkStream createDirectCommitWorkStream(
+ WindmillConnection connection, ThrottleTimer commitWorkThrottleTimer) {
+ return GrpcCommitWorkStream.create(
+ connection.backendWorkerToken(),
+ responseObserver ->
connection.stub().commitWorkStream(responseObserver),
+ grpcBackOff.get(),
+ newStreamObserverFactory(NO_DEADLINE),
Review Comment:
moved this and cleaned it up.
we already default to 10m anyways and we don't pass this deadline to the
stub so its ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
