m-trieu commented on code in PR #32775:
URL: https://github.com/apache/beam/pull/32775#discussion_r1801622080
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/FanOutStreamingEngineWorkerHarness.java:
##########
@@ -80,32 +80,39 @@
public final class FanOutStreamingEngineWorkerHarness implements
StreamingWorkerHarness {
private static final Logger LOG =
LoggerFactory.getLogger(FanOutStreamingEngineWorkerHarness.class);
- private static final String PUBLISH_NEW_WORKER_METADATA_THREAD =
"PublishNewWorkerMetadataThread";
- private static final String CONSUME_NEW_WORKER_METADATA_THREAD =
"ConsumeNewWorkerMetadataThread";
+ private static final String WORKER_METADATA_CONSUMER_THREAD_NAME =
+ "WindmillWorkerMetadataConsumerThread";
+ private static final String STREAM_MANAGER_THREAD_NAME =
"WindmillStreamManager-%d";
private final JobHeader jobHeader;
private final GrpcWindmillStreamFactory streamFactory;
private final WorkItemScheduler workItemScheduler;
private final ChannelCachingStubFactory channelCachingStubFactory;
private final GrpcDispatcherClient dispatcherClient;
- private final AtomicBoolean isBudgetRefreshPaused;
- private final GetWorkBudgetRefresher getWorkBudgetRefresher;
- private final AtomicReference<Instant> lastBudgetRefresh;
+ private final GetWorkBudgetDistributor getWorkBudgetDistributor;
+ private final GetWorkBudget totalGetWorkBudget;
private final ThrottleTimer getWorkerMetadataThrottleTimer;
- private final ExecutorService newWorkerMetadataPublisher;
- private final ExecutorService newWorkerMetadataConsumer;
- private final long clientId;
- private final Supplier<GetWorkerMetadataStream> getWorkerMetadataStream;
- private final Queue<WindmillEndpoints> newWindmillEndpoints;
private final Function<WindmillStream.CommitWorkStream, WorkCommitter>
workCommitterFactory;
private final ThrottlingGetDataMetricTracker getDataMetricTracker;
+ private final ExecutorService windmillStreamManager;
+ private final ExecutorService workerMetadataConsumer;
+ private final Object metadataLock;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
