m-trieu commented on code in PR #32775:
URL: https://github.com/apache/beam/pull/32775#discussion_r1803919198
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/WindmillStream.java:
##########
@@ -56,10 +56,11 @@ public interface WindmillStream {
@ThreadSafe
interface GetWorkStream extends WindmillStream {
/** Adjusts the {@link GetWorkBudget} for the stream. */
- void adjustBudget(long itemsDelta, long bytesDelta);
+ void setBudget(long newItems, long newBytes);
- /** Returns the remaining in-flight {@link GetWorkBudget}. */
- GetWorkBudget remainingBudget();
+ default void setBudget(GetWorkBudget newBudget) {
Review Comment:
Done
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDirectGetWorkStream.java:
##########
@@ -110,19 +113,24 @@ private GrpcDirectGetWorkStream(
streamRegistry,
logEveryNStreamFailures,
backendWorkerToken);
- this.request = request;
+ this.requestHeader = requestHeader;
this.getWorkThrottleTimer = getWorkThrottleTimer;
this.workItemScheduler = workItemScheduler;
this.workItemAssemblers = new ConcurrentHashMap<>();
- this.heartbeatSender = Suppliers.memoize(heartbeatSender::get);
- this.workCommitter = Suppliers.memoize(workCommitter::get);
- this.getDataClient = Suppliers.memoize(getDataClient::get);
- this.inFlightBudget = new AtomicReference<>(GetWorkBudget.noBudget());
- this.nextBudgetAdjustment = new
AtomicReference<>(GetWorkBudget.noBudget());
- this.pendingResponseBudget = new
AtomicReference<>(GetWorkBudget.noBudget());
+ this.heartbeatSender = heartbeatSender;
+ this.workCommitter = workCommitter;
+ this.getDataClient = getDataClient;
+ this.maxGetWorkBudget =
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
