m-trieu commented on code in PR #32775:
URL: https://github.com/apache/beam/pull/32775#discussion_r1801664651
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/WindmillStreamSender.java:
##########
@@ -154,18 +156,13 @@ void closeAllStreams() {
}
@Override
- public void adjustBudget(long itemsDelta, long bytesDelta) {
- getWorkBudget.set(getWorkBudget.get().apply(itemsDelta, bytesDelta));
+ public void setBudget(long items, long bytes) {
+ getWorkBudget.set(getWorkBudget.get().apply(items, bytes));
if (started.get()) {
Review Comment:
that is in this PR https://github.com/apache/beam/pull/32774 and i added
synchronization there
this is still the memoized Supplier.get() which is threadsafe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
