m-trieu commented on code in PR #32775:
URL: https://github.com/apache/beam/pull/32775#discussion_r1801622798
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDirectGetWorkStream.java:
##########
@@ -165,46 +170,49 @@ private static Watermarks createWatermarks(
.build();
}
- private void sendRequestExtension(GetWorkBudget adjustment) {
- inFlightBudget.getAndUpdate(budget -> budget.apply(adjustment));
- StreamingGetWorkRequest extension =
- StreamingGetWorkRequest.newBuilder()
- .setRequestExtension(
- Windmill.StreamingGetWorkRequestExtension.newBuilder()
- .setMaxItems(adjustment.items())
- .setMaxBytes(adjustment.bytes()))
- .build();
-
- executor()
- .execute(
- () -> {
- try {
- send(extension);
- } catch (IllegalStateException e) {
- // Stream was closed.
- }
- });
+ /**
+ * @implNote Do not lock/synchronize here due to this running on grpc serial
executor for message
+ * which can deadlock since we send on the stream beneath the
synchronization. {@link
+ * AbstractWindmillStream#send(Object)} is synchronized so the sends are
already guarded.
+ */
+ private void sendRequestExtension(GetWorkBudget extension) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
