lostluck commented on code in PR #33337: URL: https://github.com/apache/beam/pull/33337#discussion_r1881362265
########## CHANGES.md: ########## @@ -68,6 +68,8 @@ ## New Features / Improvements * X feature added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)). +* Support OnWindowExpiration in Prism ([#32211](https://github.com/apache/beam/issues/32211)). + * This enables initial Java GroupIntoBatches support. Review Comment: So, "@" based annotations are a notion in Java, and "@" indicates a Decorator in Python, which doesn't perform the same task as they do in Java. We want to refer to the Beam feature, not list the specific and complete manifestations of that feature in all SDK languages, so we can't use `@OnWindowExpiration`. It's immaterial that the feature currently only exists in Java, and not the other SDKs. What we could do, in a separate PR, is update the programming guide for the feature, and link to that. Then it would be pointing to the documentation for all SDKs, without fitting to a single SDK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
