lostluck commented on code in PR #33337:
URL: https://github.com/apache/beam/pull/33337#discussion_r1881385373
##########
sdks/go/pkg/beam/runners/prism/internal/jobservices/management.go:
##########
@@ -182,8 +182,6 @@ func (s *Server) Prepare(ctx context.Context, req
*jobpb.PrepareJobRequest) (_ *
check("TimerFamilySpecs.TimeDomain.Urn",
spec.GetTimeDomain(), pipepb.TimeDomain_EVENT_TIME,
pipepb.TimeDomain_PROCESSING_TIME)
}
- check("OnWindowExpirationTimerFamily",
pardo.GetOnWindowExpirationTimerFamilySpec(), "") // Unsupported for now.
Review Comment:
I don't quite understand this question. What would an input PCollection be
if it wasn't a PCollection?
In some ways it's both.
I can say it's the SDK's responsibility to send the runner well formed
Directed Acyclic Graphs as Pipelines. This lets it produce better error
messages than the runner can.
But, it's the Runner's responsibility to validate that the SDK is doing so,
and report that as an error or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
