lostluck commented on code in PR #33337:
URL: https://github.com/apache/beam/pull/33337#discussion_r1881371504
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -628,6 +655,11 @@ type Block struct {
Transform, Family string
}
+// StaticTimerID represents the static user identifiers for a timer.
+type StaticTimerID struct {
+ Transform, TimerFamily string
Review Comment:
Transform is the direct ID of a single transform, it's immaterial whether
it's in a stage or not.
Stages (and their IDs) represent fused, topologically sorted transforms.
Essentially, within Beam, everything has it's own ID, and we generally refer to
things by ID, instead of by direct code (except for Schema Row types, which is
why they're awkward).
The goal is to avoid putting SDK specific information in Prism, so referring
to an SDK specific implementation isn't useful, unless you already know that
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
