lostluck commented on code in PR #33337:
URL: https://github.com/apache/beam/pull/33337#discussion_r1881364492
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -194,9 +195,10 @@ type ElementManager struct {
pcolParents map[string]string // Map from pcollectionID to stageIDs
that produce the pcollection.
- refreshCond sync.Cond // refreshCond protects the following
fields with it's lock, and unblocks bundle scheduling.
- inprogressBundles set[string] // Active bundleIDs
- changedStages set[string] // Stages that have changed and need
their watermark refreshed.
+ refreshCond sync.Cond // refreshCond protects the following
fields with it's lock, and unblocks bundle scheduling.
+ inprogressBundles set[string] // Active bundleIDs
+ changedStages set[string] // Stages that have changed and need
their watermark refreshed.
+ sideChannelBundles []RunBundle // Represents ready to executed bundles
prepared on the side by a stage instead of in the main loop, such as for
onWindowExpiry, or for Triggers.
Review Comment:
Dropping "channel", so it's just injectedBundles.
It's not useful to overspecify the conditions why/when a bundle would be
injected this way. It is useful to describe situations that do
(onWindowExpiration), or will (triggers). Those specific locations (which can
be found by finding where this field is used) can document the conditions where
they apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
