Abacn commented on code in PR #34915:
URL: https://github.com/apache/beam/pull/34915#discussion_r2093259883
##########
.github/workflows/beam_LoadTests_Java_CoGBK_Dataflow_V2_Batch_JavaVersions.yml:
##########
@@ -95,8 +95,7 @@ jobs:
with:
gradle-command: :sdks:java:testing:load-tests:run
arguments: |
- -PtestJavaVersion=${{ matrix.java_version }} \
- -Pjava${{ matrix.java_version }}Home=$JAVA_HOME_${{
matrix.java_version }}_X64 \
+ -PjavaVersion=${{ matrix.java_version }} \
Review Comment:
> it affect the JDK selection for all JavaCompile, JavaExec and Test tasks
>
> Using a single compiler version would hide these issues until the next
time this build configuration changes the minimum supported JDK version.
Said differently, after this change it adds requirements for Beam to build
on all supported Java versions (for components with versioning tests.
Previously, it only requires tests build and run on supported Java versions,
that is aligned with user adoption scenarios). This significantly increases
scope of maintainence. Most importantly it would make new JDK support harder
and delayed - when I did JDK21 support, at first Gradle 8.3- didn't support
build on JDK21, but the work can proceed because we only need to make sure Beam
runs on JDK21 fine. It won't be possible after this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
