Abacn commented on code in PR #34915:
URL: https://github.com/apache/beam/pull/34915#discussion_r2093680512
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1845,21 +1674,7 @@ class BeamModulePlugin implements Plugin<Project> {
project.ext.includeInJavaBom = configuration.publish
project.ext.exportJavadoc = configuration.exportJavadoc
- boolean publishEnabledByCommand = isRelease(project) ||
project.hasProperty('publishing')
- if (forkJavaVersion == '') {
- // project needs newer version and not served.
- // If not publishing ,disable the project. Otherwise, fail the build
- def msg = "project ${project.name} needs newer Java version to
compile. Consider set -Pjava${project.javaVersion}Home"
- if (publishEnabledByCommand) {
- throw new GradleException("Publish enabled but " + msg + ".")
Review Comment:
Thanks. with this change GitHub Action now passed.
However my original question remains. `./gradlew
:sdks:java:container:agent:build` on java8 still failing. My point is we don't
want it to fail. User or IDE (especially true for IntelliJ) often invoke a
single `./gradlew <command>` like `./gradlew build` instead of specifying
module. Currently it works if only a single java8/11 installed. I don't think
we want to break them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
