Abacn commented on code in PR #34915:
URL: https://github.com/apache/beam/pull/34915#discussion_r2093684778
##########
.github/actions/setup-environment-action/action.yml:
##########
@@ -70,11 +70,16 @@ runs:
tox-${{ runner.os }}-py${{ inputs.python-version == 'default' &&
'39' || inputs.python-version }}-
- name: Install Java
- if: ${{ inputs.java-version != '' }}
+ if: ${{ inputs.java-version != 'default' && '11' }}
Review Comment:
It's using zulu jdk 11 actually -
https://github.com/apache/beam/blob/cbe100a53a34abdea80ac2335d36d2297d0f578c/.github/gh-actions-self-hosted-runners/arc/images/Dockerfile#L43
> OpenJDK it's also subtly different from the Temurin release
Yeah this is a good point. Strictly speaking we should use tumerin there
But Beam repo has many other tests doesn't require JDK. It justs need a java
runtime to run gradle. I don't think we want to install JDK on every single
workflow run (e.g. those python/go/website tests). Arguably Java package is
much heavier than Python/Go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
