Abacn commented on code in PR #34915:
URL: https://github.com/apache/beam/pull/34915#discussion_r2093422662
##########
.github/workflows/beam_LoadTests_Java_CoGBK_Dataflow_V2_Batch_JavaVersions.yml:
##########
@@ -95,8 +95,7 @@ jobs:
with:
gradle-command: :sdks:java:testing:load-tests:run
arguments: |
- -PtestJavaVersion=${{ matrix.java_version }} \
- -Pjava${{ matrix.java_version }}Home=$JAVA_HOME_${{
matrix.java_version }}_X64 \
+ -PjavaVersion=${{ matrix.java_version }} \
Review Comment:
> I think the next step would be to use the test suite plugin to copy the
default test test suite target and configure each Test task to override
javaLauncher, producing :path:to:project:test8 and :path:to:project:test11 for
example.
Yeah, this sounds a good idea replacing `-PtestJavaVersion=xx -PjavaxxHome`
that is used currently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
